Repository navigation
Conversation
mattrpav
changed the title
jeanouii
reviewed
Oct 29, 2026
| connection.start(); | ||
| producer.send(session.createTextMessage("probe")); | ||
| assertTrue("message not delivered", received.await(10, TimeUnit.SECONDS)); | ||
| assertTrue(Wait.waitFor(() -> received.getCount() == 0, 1000, 10)); |
Contributor
There was a problem hiding this comment.
Detail, but this is useless if the previous latch assert is true the count is 0.
jeanouii
previously approved these changes
Oct 29, 2026
jeanouii
left a comment
jeanouii
left a comment
Contributor
There was a problem hiding this comment.
I think it looks ok.
Did not run it with JDK21+ and CI only gives JDK 17 so without virtual threads.
Contributor
Author
jeanouii
reviewed
Oct 29, 2026
Contributor
|
The commit should say fix when you squash in my opinion (similar to the PR fix:) instead of feat: as it is today. |
mattrpav
force-pushed
the
fix-client-virtual-thread
branch
from
October 30, 2026 14:16
817048f to
2e94028
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans-up virtual thread support for client-side (esp failover transport) thread usage.
Note: Virtual Thread executor is shared JVM-wide, so no need to inject the executor